Clone names can't be overridden

Question

Closed this issue 8 years ago · 9 comments

https://github.com/puppet-community/puppet-corosync/blob/master/lib/puppet/provider/cs_clone/pcs.rb#L59 sets the clone's CIB ID to <primitive>-clone, which is an arbitrary naming convention. The CIB ID should simply honor the cs_clone resource's namevar, name.

Answer 1 · 2015-10-14T15:29:40.000Z

@fghaas are you interested in providing your patch as pull-request?

i absolutely agree that create MUST NOT change name (or the namevar, in general)

Answer 2 · 2015-11-02T09:22:22.000Z

@fghaas do you suggest to not add the "-clone" postfix?

Answer 3 · 2015-11-02T09:24:28.000Z

@bogdando I am suggesting to not override the user's choice for the namevar at all.

Answer 4 · 2015-11-03T09:53:18.000Z

That makes sense I believe

Answer 5 · 2016-02-29T00:58:43.000Z

Is this related to #176?

Answer 6 · 2016-02-29T07:11:59.000Z

That is more complex AFAIK because the clone is different than the primtive

Answer 7 · 2016-09-15T12:47:47.000Z

@fghaas That was a nice one as PCS does not support arbitrary id's for clones.

Answer 8 · 2016-09-15T19:58:41.000Z

@roidelapluie Cool, thanks!

Answer 9 · 2016-09-15T20:01:22.000Z

I plan to release a 5.0.0-beta 3 within the next days