Disallowing 1-primitive groups in cs_group is pointless

Question

Disallowing 1-primitive groups in cs_group is pointless

Opened this issue 9 years ago · 11 comments

The validation check in https://github.com/puppet-community/puppet-corosync/blob/master/lib/puppet/type/cs_group.rb#L30 is overzealous. It is a perfectly valid use case to have groups with just 1 primitive. For example, you might want to define a set of 3, 2 or even just 1 resource that you then reference from a constraint. The easiest way to that is to use a group, and to always have the constraint point to the group. If there is only one primitive in the group, so be it.

The alternative is to have manifests full of ifs and unlesses to either point to a group or to a standalone primitive, and that's just silly.

igalic commented 9 years ago

no :(

Answer 1 · 2015-07-14T23:26:11.000Z

For the stab I took at this that GitHub has duly cross-referenced, I of course forgot about Puppet's oh-so-smart single-element array munging as outlined in https://tickets.puppetlabs.com/browse/PUP-1299.

Answer 2 · 2015-10-14T15:32:20.000Z

@fghaas are you interested in providing your patch as pull request?

Answer 3 · 2015-10-14T15:40:26.000Z

@igalic, do you have a workaround for PUP-1299 that works pre-4.0?

Answer 4 · 2016-02-29T00:59:25.000Z

Is this still an issue?

Answer 5 · 2016-09-14T14:24:12.000Z

I believe so, yes.

Answer 6 · 2016-09-15T16:05:58.000Z

closed by #368

Answer 7 · 2016-09-15T16:22:28.000Z

Agreed. 👍

I'll leave this open for a time because I think I can produce a follow-up PR that saves a small amount of leg-work.

Answer 8 · 2016-09-16T07:43:25.000Z

Hmm, this should have auto-closed when #368 was merged. After all there is a comment to that effect in bd4268e.

It looks like fixes is a valid keyword, while fixes issue is not. Sorry about that!

Answer 9 · 2016-09-16T07:49:49.000Z

@fghaas regarding @ffrank's comment we will let this open

Answer 10 · 2018-01-07T11:07:58.000Z

@ffrank, do you still want to produce a follow-up PR?