Warning after latest changes merged

Question

Warning after latest changes merged

Closed this issue 8 years ago · 10 comments

Hi community,

after latest changes merged I got this warning

Warning: cs_primitive.rb[operations]: Role in the operations name is now deprecated. Please use an array of hashes and put the role in the values.
(at /opt/puppetlabs/puppet/cache/lib/puppet/type/cs_primitive.rb:103:in `block (4 levels) in <top (required)>')

I know it's not a major error, just be advised

Answer 1 · 2016-03-15T10:33:35.000Z

This is not a bug, it is something I did add to the provider. It means that you should adapt your puppet code:

you probably have:

operation => {'monitor:master':'interval' =>'10s', 'monitor':'interval' =>'10s'}

That should become:

operation => [{'monitor': 'role' => 'master', 'interval' =>'10s'}, {'monitor':'interval' =>'10s'}]

Answer 2 · 2016-03-15T10:34:44.000Z

I made that because it is more explicit. It is also in line with other puppet modules (e.g the alias parameter of apache::vhost).

Answer 3 · 2016-03-15T11:31:10.000Z

Uh, I believe such polishings should be done after module generally starts working as expected, not to bring more confusion. Thanx anyway for clarification

Answer 4 · 2016-03-15T11:34:16.000Z

what do you mean "after module generally starts working as expected," ?

This is a polishing that I made after your issue #234 . It will land in releade 1.0.0 - which is a major version bump. That allows us to intoduce big changes like this, dont' you agree?

Answer 5 · 2016-03-15T11:35:19.000Z

Also, I took care to ensure that old configuration are still working. they just produce a depreciation warning.

Answer 6 · 2016-03-15T12:20:28.000Z

I mean for now it does not work as expected since we have a lot of open issues. And I recheck that each time after I notice master branch updates for several months already. For now it still does not allow to tune up corosync/pacemaker cluster without errors. Maybe my config is something exotic, though I took it from some basic manual.

My testing method is the following: I manually tuned up Corosync cluster and now I try to describe these working settings with Puppet. After each merge into master I clone updated module and try to apply puppet code. For now it throws various errors and I open issues when there's new one. But code nevertheless remains the same because it describes tested and working Corosync parameters.

When now module syntax changes are made it leads to additional errors, though I believe it's something really minor to do. It's like decorating your room when walls building still not finished :) Sorry, maybe I'm too rough here, just wanted to share my thoughts

Answer 7 · 2016-03-15T12:26:35.000Z

I understand your feeling.

Would you like to open a few more issues maybe? I see nothin really important in the issues list that would prevent it to work without any error.

Answer 8 · 2016-03-15T12:46:46.000Z

Well my major problem is still not resolved, though the ticket was closed. It was regarding pcs command syntax, I remember the ticket was closed to resolve the problem in other one. But anyway I tested today and problem persists

Answer 9 · 2016-03-15T12:55:50.000Z

I reopened.

However it was not closed by magic. We are testing the puppet you sent to us:
https://github.com/voxpupuli/puppet-corosync/blob/master/spec/acceptance/cs_primitive_spec.rb
and it works in the acceptance checks.

Answer 10 · 2016-03-15T13:21:48.000Z

Closing in favor of #199