Catalog compilation should not fail when set_votequorum=true and cluster_name is set (but quorum_members and multicast_address are not)

[antaflos]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 6.7.0
• Ruby: 2.5.5
• Distribution: Ubuntu 16.04, 18.04
• Module version: master

How to reproduce (e.g Puppet code you use)

corosync::set_votequorum: true
corosync::quorum_members: []
corosync::multicast_address: []
corosync::cluster_name: mycluster

What are you seeing

Catalog compilation fails because the module requires quorum_members or multicast_address to be set when set_votequorum is true. This is wrong because setting cluster_name obviates setting multicast_address (multicast addresses are generated automatically based on the cluster name).

What behaviour did you expect instead

Catalog compilation should not fail. Multicast is sufficiently set up when cluster_name is set.