voxpupuli/puppet-icingaweb2

icingaweb2 2.11.4 changed package layout, breaks icingaweb2::module::monitoring

andrekeller opened this issue · 10 comments

andrekeller commented

Expected Behavior

for icingaweb2 >= 2.11.4 icingaweb2::module::monitoring should not install package icingaweb2-module-monitoring

Current Behavior

Between puppet runs alternativly icingaweb2 and icingaweb2-module-monitoring packages are installed, as the later removes the first upon installation.

Your Environment

  • Module version: 3.7.2
  • Puppet version: 7.21.0
  • Operating System and version: Ubuntu 20.04 LTS
lbetz commented

Please checkout solution describe in #348

andrekeller commented

@lbetz maybe I'm missing something, but this really does not solve the issue here.

Package icingaweb2-module-monitoring lists that it will break icingaweb2 in its dependencies, as a consequence apt will remove package icingaweb2 once it installs icingaweb2-module-monitoring:

$ sudo apt-get install --dry-run icingaweb2-module-monitoring
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following packages were automatically installed and are no longer required:
  icinga-l10n icinga-php-common icinga-php-library icinga-php-thirdparty icingacli icingaweb2-common php php-icinga php-intl php-ldap
  php-mysql php-pgsql php-soap php7.4 php7.4-intl php7.4-ldap php7.4-pgsql php7.4-soap
Use 'sudo apt autoremove' to remove them.
The following packages will be REMOVED:
  icingaweb2
The following NEW packages will be installed:
  icingaweb2-module-monitoring
0 upgraded, 1 newly installed, 1 to remove and 0 not upgraded.
Remv icingaweb2 [2.11.4-1+ubuntu20.04]
Inst icingaweb2-module-monitoring (2.11.4-3+ubuntu20.04 ubuntu icinga-focal:icinga-focal [all])
Conf icingaweb2-module-monitoring (2.11.4-3+ubuntu20.04 ubuntu icinga-focal:icinga-focal [all])
lbetz commented

Package is available and used ny class icingaweb2::module::monitoring by default. What kind of repository you use?

https://packages.icinga.com/ubuntu/pool/main/i/icingaweb2-module-monitoring/icingaweb2-module-monitoring_2.11.4-1+ubuntu20.04_all.deb

lippserd commented

We're at version 2.11.4-3 now. Before, there was no breaks which would have replaced the monitoring module completely. Icinga Web has to be upgraded to version 2.11.4 in order to install this icingaweb2-module-monitoring transition package.

lbetz commented

@lippserd good point. I have overlooked:
Remv icingaweb2 [2.11.4-1+ubuntu20.04]

andrekeller commented

We're at version 2.11.4-3 now. Before, there was no breaks which would have replaced the monitoring module completely. Icinga Web has to be upgraded to version 2.11.4 in order to install this icingaweb2-module-monitoring transition package.

If that was the intention, then the breaks is probably incorrect.
Shouldn't it be

Breaks: icingaweb2 (<< 2.11.4-1+ubuntu20.04)

instead?

There is no version 2.11.4-3+ubuntu20.04 published for package icingaweb2 as far as I can see

  • 👍1
lippserd commented

Give me a second.

lippserd commented

Uploaded 2.11.4-4 which hopefully fixes the Breaks. However, due to the changed dependencies, the upgrade needs to be done with the following command I think:

apt install --only-upgrade icingaweb2

andrekeller commented

I can confirm that installing the updated version of icingaweb2-modules-monitoring no longer breaks the icingaweb2 "base" package.

The puppet module should probably be updated at some point anyway, as it does not make much sense to install this transition package unless you are upgrading from a previous release imho.

Thanks for the fast reaction and fix though 👍

lbetz commented

Exactly, not only older versions of the puppet module have to be supported, but especially old Iicnga package versions.