If "create_mode" is set and "create" is set to false then error should not be thrown

[alphahelixx]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet:
  5.5.4
• Module version:
  3.3.0

How to reproduce (e.g Puppet code you use)

Set create_mode to something and set create to false:

What are you seeing

Error being thrown

What behaviour did you expect instead

create_mode being ignored if set and create set to false .

Output log

Any additional information you'd like to impart

The lograte.conf.erb already does ignore it, so why have a specific error message?

***** SNIP *****
if @create
opts << ['create', @create_mode, @create_owner, @create_group].reject { |r|
r == nil
}.join(' ')
elsif @create == false
opts << 'nocreate'
end
***** SNIP *****

***** SNIP puppet code *****
if $create_mode and !$create {
fail("Logrotate::Conf[${name}]: create_mode requires create")
}

***** SNIP puppet code *****