voxpupuli/puppetboard

Puppetdb health check on homepage

ArthurWuTW opened this issue · 3 comments

ArthurWuTW commented

I was in the situation my puppetdb was dead, and I had no any evidence on puppetboard, because I got internal server error from it.
So I was wondering to add a feature to show puppetdb connection status on puppetboard homepage.

  • Able to show homepage even if puppetdb connection failed.
  • Able to show homepage after puppetdb start and no agent yet.
  • Add a puppetdb connection status hint on the banner.

I've already done this feature and it looks like...

  • Run puppetboard only
    image

  • Run puppetboard and puppetdb, but no agent yet
    image

  • Run puppetboard and puppetdb with agents
    image

any suggestions?

gdubicki commented

Hi @ArthurWuTW!

Thanks for reporting this and taking the time to propose specific UI changes. :) I agree that currently Puppetboard handles cases where PuppetDB is not working or when it is empty particularly badly.

However I think that on the first screenshot the content is contradicting itself - if the PuppetDB connection has failed then the Puppetboard doesn't know what are the numbers of nodes in each state, so it should not show zeros. How about we show something like this in such case instead:

Screenshot 2022-06-06 at 08 34 03

What do you think?

Also we really should finally fix #515 and #562 by showing something helpful when the PuppetDB is empty/doesn't contain anything in a given env. This would require some investigation about how to distinguish these cases though.

ArthurWuTW commented

yeah you are right, error message is enough
I just modified the code to have error message when puppetdb connection failed.
No need to have the status red/green lights on the banner as well.

gdubicki commented

Released in v3.6.0. Thanks again for your contribution, @ArthurWuTW!

  • 😄1