Filtering doesn't work on Facts view

Question

Filtering doesn't work on Facts view

gdubicki opened this issue 2 years ago · 3 comments

Describe the bug

When you enter some text in the "type here to filter" text field in Facts view the facts below are not filtered - nothing happens.

Puppetboard version

4.1.0rc2

(Note: this bug does not occur in 4.0.5.)

Environment and installation method

Centos 7 and Python 3.8 from Software Collections, installed with the Forge module and using the git repo tag.

Answer 1 · 2022-09-23T14:14:11.000Z

Can you please take a look at this, @melck? I suppose it's related to the big frontend update.

Answer 2 · 2022-09-24T10:46:20.000Z

I fixed it but I would appreciate your review for the PR above, @melck, as I am not good at frontend and am afraid that I might have broken something else with this, especially as I touched some of the code that you added.

Answer 3 · 2022-09-26T10:20:09.000Z

@gdubicki Indeed i forgot to refactor fact filtering. I removed this part because we don't need coffeescript. I reused your branch on my fork to fix it and i will try a PR on it.