voyagermesh/voyager

ImagePullSecrets gone from ServiceAccount spec

gre9ory opened this issue · 1 comments

It seems as if the possibility of having imagePullSecrets in the ServiceAccount template is lost.

I can see that referencing imagePullSecrets via the ServiceAccount was added here in December 2019:

#1465

Now in the current version (v12/v13) they are gone which prevents running the chart against a private Docker registry.
I think the charts current code is to be found here?

https://github.com/voyagermesh/installer/blob/release-13.0/charts/voyager/templates/serviceaccount.yaml

Can they be re-added?

Additional comment:

ImagePullSecrets are again part of the Deployment template which leads me to believe that

#1465

(which also removed them from the Deployment template) just might not be part of current Helm chart releases.

Maybe a simple merge is missing.