vpetrigo/caches

Pass map as template param to replace unorder_map

westfly opened this issue · 4 comments

westfly commented

Online module have another map instead of unorder_map, could this caches module support thirdparty map implement?

vpetrigo commented

Right now it is not supported. Current implementation relies only on the std::unordered_map container.
It should be pretty straight forward to update it to support an unordered_map compatible container though.

If you wish you may prepare a PR. I'll be more than happy to accept it.

westfly commented

Indeed I tried, but the solution is not elegant as the param of map too complex .

master...westfly:caches:map_param

I will try to find other solution to give an PR asap

vpetrigo commented

Would you check the commit fd8331c? I added a template parameter that should allow you to pass a custom HashMap implementation. See tests implementation to check out this feature with the parallel-hashmap.

  • 👍1
westfly commented

Would you check the commit fd8331c? I added a template parameter that should allow you to pass a custom HashMap implementation. See tests implementation to check out this feature with the parallel-hashmap.

thx, it's work for me

  • ❤️1