vpython/vpython-jupyter

Shape roundness bug

ianzur opened this issue · 3 comments

ianzur commented

Using shape roundness argument results in extrusion missing front and end faces.

from vpython import *

print(version)
print(GSversion)

### works as expected
# rt = shapes.rectangle(width=3, height=3)

### start and end faces missing
rt = shapes.rectangle(width=3, height=3, roundness=0.1)

extrusion(
    path=[vec(0,0,0), vec(0,0,-0.1)],
    shape=rt
    )

bug

['7.6.1', 'jupyter']
['2.9', 'glowscript']

BruceSherwood commented

Thanks much for this detailed report. Will look into it.

BruceSherwood commented

Replace .../Lib/site-packagesvpython/shapespath.py with this file:
https://github.com/vpython/vpython-jupyter/blob/master/vpython/shapespaths.py
The next release of VPython 7 will contain this fix, which turned out to be an off-by-one error in generating points along the shape.

ianzur commented

Thank you for the quick fix Bruce!