vrimar/construct-ui

Base height cannot be configured for default or smaller components

raykyri opened this issue · 1 comments

raykyri commented

In src/_shared/_variables.scss, is there any reason !default is set on lg and xl sizes but not on smaller sizes?

$cui-base-height:     $cui-base-size * 4;
$cui-base-height-xs:  $cui-base-size * 3;
$cui-base-height-sm:  $cui-base-size * 3.5;
$cui-base-height-lg:  $cui-base-size * 4.5 !default;
$cui-base-height-xl:  $cui-base-size * 5 !default;
vrimar commented

An oversight on my part, thanks! I've added the !default overrides to all missing variables in v0.2.6.

  • 🎉1