"All" selector not working?

Question

marcosnils opened this issue 3 years ago · 5 comments

IIUC from this example (https://github.com/vrothberg/vgrep#more-commands-and-the-interactive-shell) I could use an "all" selector to edit all the matched expressions, is that correct? I'm getting a "unsupported command 'all'" when trying to use that.

$ vgrep -s all
unsupported command "all"

Am I missing something here?

Answer 1 · 2021-11-12T10:14:14.000Z

Thank you for reaching out, @marcosnils!

That's possibly a regression when porting vgrep from python to go a couple of years ago. Interested in opening a PR?

Answer 2 · 2021-11-12T10:16:58.000Z

Sure, will send a fix today.

Answer 3 · 2021-12-02T18:39:19.000Z

Are you still interested? If you don't find time, no problem at all. I can take over if needed.

Answer 4 · 2021-12-02T18:45:47.000Z

Hey Valentin, Still interested but have very little time TBH. Please go ahead and take it over if you have the time to work on it. Cheers!

On Thu, Dec 2, 2021 at 3:39 PM Valentin Rothberg ***@***.***> wrote: Are you still interested? If you don't find time, no problem at all. I can take over if needed. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#165 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMBLWRFNTJMNGS5RJ4PTV3UO64ODANCNFSM5HYL72IQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

Answer 5 · 2021-12-02T19:03:21.000Z

Thanks, I tracked it down to a malformed regex. It's working now :)