vsgImGui configuration is broken

Question

vsgImGui configuration is broken

Closed this issue 2 years ago · 5 comments

The last commit broke the configuration:

-- The CXX compiler identification is AppleClang 14.0.0.14000029
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Vulkan: /usr/local/lib/libvulkan.dylib (found suitable version "1.3.231", minimum required is "1.1.70.0") found components: glslc glslangValidator
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found glslang: /usr/local/lib/libglslang.a
CMake Error at CMakeLists.txt:24 (vsg_setup_dir_vars):
Unknown CMake command "vsg_setup_dir_vars".

-- Configuring incomplete, errors occurred!

Answer 1 · 2022-11-08T18:16:49.000Z

I just tested a clean build and vsgImGui master is working OK for me. It now relies up changes checked into VSG master, is there a chance you didn't update and install the VSG?

Answer 2 · 2022-11-08T18:43:16.000Z

I just repeated the complete build process, starting with vsg, followed by vsgXchange. vsgXchange also needs vsg and was working. Also vsgExamples configures and builds well (without vsgimgui_examples) with vsg.
cmake complains with vsgImGui. Kicking out the commit 7af6467 make things work again.
Maybe important: I used branch VulkanSceneGraph-1.0.

Answer 3 · 2022-11-08T19:13:20.000Z

On Tue, 8 Nov 2022 at 18:43, Rainer Gericke ***@***.***> wrote: I just repeated the complete build process, starting with vsg, followed by vsgXchange. vsgXchange also needs vsg and was working. Also vsgExamples configures and builds well (without vsgimgui_examples) with vsg. cmake complains with vsgImGui. Kicking out the commit 7af6467 <7af6467> make things work again. Maybe important: I used branch VulkanSceneGraph-1.0.Message ID: ***@***.***>

The changes won't work with the VulkanSceneGraph-1.0 branch at this point. You'll need to use VSG, vsgXchange and vsgExamples master. If everything works OK with the changes in VSG master I'll merge the respective masters into the *-1.0 branches, but we need testing out in the community before we know whether that is safe.

Answer 4 · 2022-11-08T19:19:44.000Z

Ok. It's all good now.

Answer 5 · 2022-11-09T09:00:08.000Z

I have merged VSG, vsgXchange, vsgExamples master into the respective 1.0 branches now so it should be fine to mix them with vsgImGui,