vsoch/docsy-jekyll

Issue: Changing assets in assets/favicons/ doesn't change icon on homepage

neotamias opened this issue · 5 comments

image
Icons are changed inside assets/favicons/

image
website doesn't change

image
built fine and it is loading as the favicon the browser is loading has changed

vsoch commented

The icon on the home page is not derived from the favicon, it's the logo.svg file in includes, linked here https://github.com/vsoch/docsy-jekyll/blob/master/_includes/header.html#L4.

thank you! can you add that to the instructions?

vsoch commented

Would you care to contribute a PR to add it?

i can do that for sure

vsoch commented

@neotamias did you plan to contribute here or should we close this?