LIcon with null size within LMarker slot fails to nullify default size

Question

LIcon with null size within LMarker slot fails to nullify default size

mryellow opened this issue 3 years ago · 14 comments

When providing an icon without a size within the default slot the icon property defaults to new Icon.Default() which has an iconSize of [12,12].

Steps to Reproduce

  <l-marker :lat-lng = "[-10, 10]">
    <l-icon :icon-size="null" :class-name="`leaflet-marker-icon`">
      <div :style="`width: 50px; height: 50px; background-color: #03f;`">Icon</div>
    </l-icon>
  </l-marker>

Expected Results

No forced sizing on marker.

Actual Results

The internal div will have the correct size, however...

Using DOM inspection tools, observe .leaflet-marker-icon wrapping this to have a size of 12x12

Browsers Affected

Versions

Leaflet: v1.7.1
Vue: v2.6.14
Vue2Leaflet: v2.7.1

Answer 1 · 2022-04-16T01:50:26.000Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Answer 2 · 2022-04-21T11:55:44.000Z

Bump. I'll cycle back someday.

Answer 3 · 2022-06-23T04:41:46.000Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Answer 4 · 2022-06-23T06:06:23.000Z

It's not stale until it's fixed and long since forgotten.

Answer 5 · 2022-08-11T02:30:02.000Z

Hi @mryellow , thank you for reporting this issue, and sorry for the lengthy delay in getting to it. Unfortunately, I don't think this is the right place to be trying to get it fixed. The behaviour you describe appears to be that of Leaflet itself.

Here are two identical maps, one made with Vue2Leaflet and the other with vanilla Leaflet.

As you can see, the rendered maps and map elements appear functionally identical, down to the 12x12 .leaflet-marker-icon div wrapping the larger div icon.

Answer 6 · 2022-08-11T05:08:54.000Z

You're probably right. I remember it being buried deep and very interconnected.

Looking back seems the null gets passed all the way through, yes resulting in a default icon but also ending up with an iconSize which is falsy all the way to Leaflet itself.

Answer 7 · 2022-10-16T05:40:07.000Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Answer 8 · 2022-10-16T20:21:39.000Z

Please go away stalebot.

Hang-ong wontfix on a "stale" issue, entirely inappropriate.

Answer 9 · 2023-01-07T18:08:52.000Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Answer 10 · 2023-01-07T20:41:15.000Z

@Stale Please just go away.

Answer 11 · 2023-03-25T09:26:24.000Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Answer 12 · 2023-03-25T23:56:53.000Z

Someone may wish to know about it stalebot.

Answer 13 · 2023-06-18T06:19:56.000Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Answer 14 · 2023-06-18T06:52:35.000Z

I still hate you stalebot.

undefined !== null