vueact/babel-plugin-transform-react-to-vue

componentDidUpdate not transformed to Vue equivalent.

nlieb opened this issue · 3 comments

nlieb commented

As in the title, componentDidUpdate is not transformed to a Vue equivalent.

can you provide example?

and i think this is equivalent of updated from vue

https://vuejs.org/v2/guide/instance.html#Instance-Lifecycle-Hooks
lifecycle

nlieb commented

It is possibly closer to beforeUpdate since it is called even when the virtual DOM is not changed (but the render function did get called via a props or state change). There are also additional parameters which would have to be modelled manually since I don't believe Vue offers a similar API for prevProps and prevState. They are described here: https://facebook.github.io/react/docs/react-component.html#componentdidupdate

In what form would you like the example to be? Currently the transform treats componentDidUpdate
like an un-special function and simply plops the method into the 'methods' Vue property.

idk, they will just need a bit more data to easier implement this (more you explain == less work they have)