vuejs/awesome-vue

PRs about Typos and Grammatical errors are not considered in the PR Template

Cyebukayire opened this issue · 5 comments

I thought there might be a type called " [ ] Chore " with a required description of the changes that have been made in the PR.
but there are only " [ ] Fix " and " [ ] Feature " types to choose from with check boxed about Apps/Websites & links.
I guess these don't apply in the case of Typos and Grammatical errors.

Was it intentional or can one add it? I just need to know

Scrum commented

You make corrections hence this point " [ ] Fix "

Too many statuses make you think about the correctness of the choice, you have only two options, either you introduce something new or you fix something

Are Grammatical error corrections considered as fixes? I thought fixes relate to code changes that affect the system functionality

Scrum commented

Are Grammatical error corrections considered as fixes? I thought fixes relate to code changes that affect the system functionality

Grammar errors as code but not for machines)

ohhh it makes sense
so, how about the Grammatical errors in files like README?

Scrum commented

so, how about the Grammatical errors in files like README?

Sounds very good