Event fired twice ** although no emit used in code **
osasson opened this issue · 2 comments
osasson commented
Version
3.2.19
Reproduction link
Steps to reproduce
Click on the labels in the reproduction
What is expected?
Event should fire only once
What is actually happening?
Event is fired twice
When merging the templates into one template, the fire 2 text fires only once :-)
LinusBorg commented
This is caused by two things:
- You needlessly binding
$attrs
to the root element, as Vue will do that on its own already (called "attribute fallthrough") and have an additional single @click listener defined. - A failure on Vue's part to detect that the same click event will be added twice when merging attrs in this fallthrough behavior. This only happens in this specific scenario where you already have two click events (which are combined in an array), and then Vue adds fallthrough events on its own.
To be precise, this line doesn't account for event arrays:
Solution/Workaround for OP:
Either remove v-bind="$attrs"
as it's not needed to assign attrs to the root element, or properly add the inheritAttrs: false
option if you want to assign $attrs manually.
We still should fix this thoug, as this incomplete check in mergerProps
could potentially affect other scenarios as well I would assume.
soulsam480 commented
just discovered this issue where the handler is getting fired two time.