Yarn v2 compat: add vue to peerDependencies
Closed this issue · 2 comments
AlexandreBonaventure commented
Version
3.1.2
Steps to reproduce
When using Typescript, vuex export types like here: https://github.com/vuejs/vuex/blob/dev/types/index.d.ts#L1 But as you can see here, it imports Vue typings to make it work. As a matter of fact vue
should be added to peerDependencies
What is expected?
vue
should be a peerDependency
What is actually happening?
it is not, and it fails in a strict dependency-tree context
Ref: vuejs/vue-cli#5135
kiaking commented
Thanks for the report! Yap, indeed we should have it as a peer dependency. PR on the way 👍
kiaking commented
And this is fixed at Vuex 3.1.3 🎉
https://github.com/vuejs/vuex/releases/tag/v3.1.3