Using `vuex` with the latest version of `vue` has a broken hot reload test
alecgibson opened this issue · 1 comments
alecgibson commented
Version
4.1.0
Describe the bug
When developing with a fork of vuex
, I noticed that vuex
tests break when bumping vue
to the latest version:
FAIL test/unit/hot-reload.spec.js
● Hot Reload › getters
expect(received).toBe(expected) // Object.is equality
Expected: 10
Received: 1
279 | })
280 |
> 281 | expect(vm.a).toBe(10)
| ^
282 | store.dispatch('check', 10)
283 |
284 | if (isSSR) {
at Object.toBe (test/unit/hot-reload.spec.js:281:18)
Reproduction
- Check out
vuejs/vuex
main
branch - Run
yarn test
- Tests pass
- Update
vue
:yarn add --dev vue@latest
- Run
yarn test
again - Tests fail
Expected behavior
Tests pass on latest version of vue
— presumably this means there's broken behaviour when using vuex
with the latest version of vue
?
Additional context
No response
Validations
- Follow our Code of Conduct
- Read the docs.
- Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
alecgibson commented
Did a bit of investigating on version numbers at least, and it looks like this broke in vue@3.4.0
. Tests pass fine in vue@3.3.13
, but fail in vue@3.4.0