vuestorefront/storefront-ui

[Bug]: SfSelect placeholder not hidden

runyasak opened this issue · 4 comments

Describe the Bug

When I passed the placeholder, the placeholder appears but it appears as a selectable option too.

Current behavior

The placeholder is appeared and can be selected.

Screen Shot 2566-04-17 at 22 30 04

Expected behavior

The placeholder should not be appeared as an option and can select.

Screen Shot 2566-04-17 at 22 30 14

Steps to reproduce

  • import and create SfSelect component
  • pass value to placeholder prop

What package and version of StorefrontUI are you using?

v2.0.0

What framework does your application use?

Vue, React

What version of Node.js are you using?

v16.17.0

What browser (and version) are you using?

Chrome

What operating system (and version) are you using?

macOS

Relevant log output

No response

Able to fix / change the documentation?

  • Yes
  • No

Code of Conduct

  • I agree to follow this project's Code of Conduct

Hey @runyasak, thank you for reporting! We will look into this ASAP :) Would you like to take care of this issue and contribute?

Hey @runyasak, thank you for reporting! We will look into this ASAP :) Would you like to take care of this issue and contribute?

Thank you so much.
Sure, I would like to contribute to this issue. 😁

@runyasak perfect, then I'm assigning it you :) Have fun coding!

@aniamusial Hi, I've created a PR for this issue.
Please, check out and review my code: #2613 😁