vuestorefront/vsf-capybara

Cannot tab between inputs in user registration modal on demo page

Closed this issue · 3 comments

Agular commented

Current behavior

On capybara demo page when arriving to user registration modal after clicking on the user icon and "Register now",
I cannot switch between all the inputs with the tab key. It only seems to switch between the email input and the close button, all other inputs are ignored.
On the other hand, switching between inputs with enter key works.

Expected behavior

By pressing the Tab key I am able to switch between all the inputs shown in the user registration modal.

Steps to reproduce the issue

Go to capybara demo page https://capybara.storefrontcloud.io/
Click on user icon
Click on register now
Press Tab to try to navigate between inputs, gets stuck between email and close button

Can you handle fixing this bug by yourself?

  • YES
  • NO

Environment details

  • Browser: Google Chrome 92.0.4515.107
  • OS: Windows 10 Enterprise, 1909
  • Capybara Demo Page @ 22.07.2021 16:42 GMT+3

Additional information

Does this happen due to content dynamically changing in the model and thus the tab order is not updated?
Reporting this currently since we have a similar situation where we use SfTabs in a modal and we have 2 inputs in the second tab and the last input is not included in the tab order

ymaheshwari1 commented

Hi @Agular, the issue is fixed in this PR: #580. You can update the code directly until the PR does not gets merged.

ymaheshwari1 commented

@dt2patel I think we can close the issue, duplicate of #434 and already solved in #580

dt2patel commented

Closing and merging mentioned PR