vultr/vultr-cli

[Feature] Two options which could probably be boolean instead of enum

Opened this issue · 0 comments

Describe the bug

There are two options in baremetal defined as enums:

create.Flags().StringP(
	"ipv6",
	"i",
	"",
	"(optional) Whether IPv6 is enabled on the server. Possible values: 'yes', 'no'. Defaults to 'no'.",
)

and

create.Flags().StringP(
	"notify",
	"n",
	"",
	`(optional) Whether an activation email will be sent when the server is ready. Possible values: 'yes', 'no'. 

Defaults to 'yes'.`,
)

I wonder why they are not defined as BoolP options. Is it intentional?

Since second option default value is yes, it would probably make sense to have --suppress-notification so users.
Also I wonder what is breaking changes policy for vultr-cli?

If it makes sense, i could create a PR.