vultr/vultr-node

[BUG] - URLSearchParams unsupported on IOS

MinisculeGirraffe opened this issue · 2 comments

MinisculeGirraffe commented

Describe the bug

Unable to preform any POST requests on IOS devices due to URLSearchParams being unsupported. GET requests are still able to be preformed due to the API key being embedded in the headers.

To Reproduce
Utilize any POST requests in the library

Expected behavior
Parameters should be URL encoded when sent from an IOS device

Screenshots
Screen Shot 1399-06-09 at 14 16 19

See screenshot sent from an IOS device using the below code

Screen Shot 1399-06-09 at 14 19 26

Desktop (please complete the following information where applicable:

  • OS: iOS
  • Language Version NodeJS 12
  • Browser Stock browser
  • Version Any

Additional context
The fix for this is to use a generic polyfill to encode the URL params.

MinisculeGirraffe commented

I submitted PR 373 to fix this issue. Confirmed on my IOS devices that this resolves the error

ddymko commented

@MinisculeGirraffe Thanks for fixing this! We created a new milestone for v0.5.0 with your change and a few others which will go out by the end of the week.