apiUrl param seems to ignore everything after /

Question

apiUrl param seems to ignore everything after /

TheFaithOne opened this issue 3 years ago · 6 comments

For internal automated tests purposes we have a mock service that is located at https://example.com/mockId/. However when the flow starts it always sends https://example.com/sdk/v2/configuration?name=flow omitting whatever path I put after .com/. It works fine for my iOS colleague so I wanted to ask if this is intended behavior and if so, what's the reasoning behind it?

Real API URL that we have from the dashboard seems to be working fine, but I would assume only because it doesn't have any additional paths.

SDK version 2.6.0

Answer 1 · 2022-02-03T10:39:28.000Z

This issue is related to url auto resolving by Retrofit library that we are using internally.
As a solution for current sdk version you can pass your url without trailing '/' ('https://example.com/mockId').
We will add support for both cases (with and without a trailing '/') in future versions of sdk.
Thanks for pointing this issue.

Answer 2 · 2022-02-04T09:50:29.000Z

Great, thanks for your prompt response. I have a feeling that SDK crashes if I don't supply trailing "/" with IllegalArgumentException, however I'm not 100% sure if this was 2.6.0 or 2.5.1. I'll give it a quick try and edit this response.

Cheers!

Answer 3 · 2022-02-04T09:57:09.000Z

I just double checked and indeed there is a problem with missing leading '/', so we will make a hot fix in a short term

…

On Fri, Feb 4, 2022 at 11:50 AM Vito ***@***.***> wrote: Great, thanks for your prompt response. I have a feeling that SDK crashes if I don't supply trailing "/" with IllegalArgumentException, however I'm not 100% sure if this was 2.6.0 or 2.5.1. I'll give it a quick try and edit this response. Cheers! — Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVWX626PRFFGVGHTPWS5FXTUZOOPDANCNFSM5NOHQYPA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you commented.Message ID: ***@***.***>

Answer 4 · 2022-02-16T12:16:43.000Z

Howdy, is there some kind of ETA for the fix/hotfix that would at least allow passing url without trailing "/"?
Thanks.

Answer 5 · 2022-02-16T15:54:04.000Z

Hi! Hopefully new version with fix will be released till end of this week

Answer 6 · 2022-02-19T16:58:26.000Z

Hiya, I can confirm that the issue has been resolved in 2.6.2 and paths are present as expected. The issue with missing trailing "/" also appears to be resolved. Thank you. However I've found some other weird behavior that I would like to ask about. As it isn't necessarily connected to this issue, I'll close this one and open a new one for discussion.