kf lists should be sorted
Closed this issue · 7 comments
see necessary hack in ValueTrackView z67, StringTrackView z62
this sort is not even as painful as the keyframe sorting in the track models on every evaluate. see https://github.com/vvvv/Timeliner/blob/master/Source/Model/ValueTrack.cs#L150
problem is, we have no sorted editable ID list... either we add one to the vvvv.core or we sort on every keyframe insertion/deletion.
i tried here https://github.com/vvvv/Timeliner/blob/master/Source/Model/ValueTrack.cs#L86 but it ditn't work.
so for now its done here on insertion: https://github.com/vvvv/Timeliner/blob/master/Source/View/ValueTrackView.cs#L68
but still would need to be done on moving kfs around. where would that be?
after moving keyframes around its basically the same problem as rebuilding the curves, so i would say together with BuildCurves() in the RebuildAfterUpdate().
... and i am wondering why the sort on add didn't work... maybe we have to reassign the list or so?
huh, aber dat can become fairly tricky. we'll have to remove kf from the svg and add them back in at their new position. so it is not only about sorting but also about remove/re-inserting the right kfs after the sort..
how about marking kfs in the movehandler? oldindex, newindex...and then do the remove/re-inserting ni RebuildAfterUpdate(). see what i mean? better ideas?