Same trigger instant may be calculated, resulting in loss of logs

The following line:

rotating-fos/src/main/java/com/vlkan/rfos/policy/TimeBasedRotationPolicy.java

Line 63 in 24b90e0

    
           long triggerDelayMillis = Duration.between(currentInstant, triggerInstant).toMillis();

rounds the delay down to the nearest millis, causing the rotation to happen <1 ms too soon. After the rotation,

rotating-fos/src/main/java/com/vlkan/rfos/policy/TimeBasedRotationPolicy.java

Line 62 in 24b90e0

Instant triggerInstant = getTriggerInstant(clock);

may calculate the same triggerInstant (because we are still ahead the previous one), causing filename duplication and overwritten files. These will happen on a properly fast machine.

Solution: add 1 ms to the delay or round up.

@broafka-ottokar, thanks so much for the report. I will see what I can do about it.

In the meantime, curious: In which application do you use rotating-fos? What is your use case?

@broafka-ottokar, 19a033e fixes the issue in two angles:

Switched to nanosecond resolution while scheduling the triggering task
Ensuring triggerInstant > lastTriggerInstant

Could you review the fix, please? If you are also okay, I will do a patch release.

@vy Looks good to me.

In the meantime, curious: In which application do you use rotating-fos? What is your use case?

These are bespoke, non public apps, mostly web, some CLI. Basically the HTTP traffic log is rotated by this lib.

@broafka-ottokar, released 0.9.7. It should be available on Maven Central momentarily.