discussion - GRPCError should implement error
moh-abk opened this issue · 2 comments
moh-abk commented
Based on the great work done in #12 - I think GRPCError should implement Error rather than GRPCStatus implementing it.
Currently you have to do example Future<SomeResponse, GRPCStatus> -- but with GRPCError containing other stuff that might be needed downstream I think it should implement Error.
Most Combine publishers require an Error as part of the return.
Thoughts?
vyshane commented
I don't have control over the GRPCError type. It belongs to upstream Swift gRPC.
RPCError does implement Error though. Did you confuse the two?
moh-abk commented
Indeed I confused them. Thanks!