w0rm/gulp-svgstore

Content loaded via ajax shows empty icons

matthewnessworthy opened this issue · 3 comments

matthewnessworthy commented

With relation to https://stackoverflow.com/questions/44245032/svg-symbols-not-loading-with-ajax-content-in-chrome

Please can you include xmlns:xlink="http://www.w3.org/1999/xlink" in the <svg/> tag definition.

Currently when content containing is loaded via ajax, icons within the content are blank.

w0rm commented

@matthewnessworthy can you open a PR that adds it here: https://github.com/w0rm/gulp-svgstore/blob/master/index.js#L18 and updates the tests?

matthewnessworthy commented

@w0rm the PR #96 has been created and the unit tests pass. Usage tests appear to be broken (but unrelated to the PR)

  • 👍1
w0rm commented

@matthewnessworthy thanks! Just published 7.0.1. I'm not sure what's happened to the usage tests