Provide TypeScript definitions
Opened this issue · 4 comments
legrego commented
Adding TS definitions would help with type safety
fabio-looker commented
Is this what would need to be added? https://www.npmjs.com/package/@types/rison
https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/rison
legrego commented
Yep, I think those typedefs would end up working for this. We'd just need to re-publish under @types/rison-node
, or include those typedefs directly in this repository. I prefer the latter approach, as it's one less dependency to maintain in downstream projects
w33ble commented
I'm also in favor of pulling types into this repo, less dependencies and also easier to keep things in sync.
tiffon commented
Btw decode_uri
is not in the linked typedefs since it is specific to rison-node.