w3c/browser-specs

Add new spec: Device Attributes API

tidoust opened this issue · 12 comments

URL

https://wicg.github.io/WebApiDevice/device_attributes/

Rationale

(One question is whether the "browser" category is the right one for "managed" APIs, but that's what we have for the Managed Configuration API)

Additional properties

{
  "shortname": "device-attributes",
  "nightly": {
    "sourcePath": "device_attributes/index.bs"
  }
}

Changes to index.json

This update would trigger the following changes in index.json:

Add spec (1)
{
  "url": "https://wicg.github.io/WebApiDevice/device_attributes/",
  "seriesComposition": "full",
  "shortname": "device-attributes",
  "series": {
    "shortname": "device-attributes",
    "currentSpecification": "device-attributes",
    "title": "Device Attributes API",
    "shortTitle": "Device Attributes API",
    "nightlyUrl": "https://wicg.github.io/WebApiDevice/device_attributes/"
  },
  "nightly": {
    "url": "https://wicg.github.io/WebApiDevice/device_attributes/",
    "status": "Draft Community Group Report",
    "sourcePath": "device_attributes/index.bs",
    "alternateUrls": [],
    "repository": "https://github.com/wicg/WebApiDevice",
    "filename": "index.html"
  },
  "organization": "W3C",
  "groups": [
    {
      "name": "Web Platform Incubator Community Group",
      "url": "https://www.w3.org/community/wicg/"
    }
  ],
  "title": "Device Attributes API",
  "source": "spec",
  "shortTitle": "Device Attributes API",
  "categories": [
    "browser"
  ],
  "standing": "good"
}

Tests

These changes look good! 😎

I think being organization owners is not enough to be considered owners of the repository. I tried to add us as "admin" of the repos, but that does not seem to change anything. Perhaps the code should rather run on MEMBER even though that's a bit loose (or hardcode our names).

(edit: seems confirmed by Check permissions in a GitHub Actions workflow)

MEMBER would work, esp if we keep the PR process as a safeguard to write access

git: 'co' is not a git command

Pff, why don't aliases propagate?

No, that still won't work ;) Need to understand how to push with gh in a context that is not my local context ;)

Spec added. Closing issue manually, see #1282 to make that automatic when PR is merged.