w3c/wai-tutorials

Fly out menu example on WAI tutorials seems to use aria-haspopup which may not be optimal

Closed this issue · 4 comments

The flyout controls page indicates haspopup should be used to indicate menus - but this structure is not a menu. Also in ARIA 1.2 haspopup is being deprecated as a global attribute and will only be usable on certain controls. I would recommend the pattern be updated to follow the ARIA authoring practices example:
Current Flyout:
https://www.w3.org/WAI/tutorials/menus/flyout/
Recommended ARIA practices approach:
https://w3c.github.io/aria-practices/examples/disclosure/disclosure-navigation.html

I think it is sufficient to remove the aria-haspopup. The rest of the example can stay as it is. The use of links instead of buttons makes more sense in a navigation

yatil commented

Version 2.0 of the page (integrating it into the current WAI design and fixing the most outrageous bugs), which was completed over 11 months ago, also still has aria-haspopup: https://wai-tutorials.netlify.app/tutorials/menus/flyout/

I agree that it can be completely removed.

yatil commented

Duplicate of #611.

aria-haspopup removed in PR #633