implement `From<<Self as engine::EngineBLS>::PublicKeyGroupAffine>`

Question

implement `From<<Self as engine::EngineBLS>::PublicKeyGroupAffine>`

Closed this issue 4 years ago · 3 comments

I have introduced auxaulary types PublicKey/SignaturePrepared to make the EngineBLS compatible with Zexe Curves but so I need to tell rust how to convert from pairing agnostic curves to the elements prepared specififcally for G1 or G2.

Answer 1 · 2020-10-26T21:02:45.000Z

If I understand then I did with the two impls for EngingBLS

Answer 2 · 2020-10-27T19:11:39.000Z

One actually need to implements From for G1Prepared and G2Prepared and then just tell rust that which one is PublicKeyPrepared and SignaturePrepared is. On the other hand these are implemented in each model (BLS12, ...) in the Zexe crate. So I don't think there is more to do with this at least for now.

Answer 3 · 2020-10-27T20:11:41.000Z

yes you coudl not impl From for a foreign type anyways