wa0x6e/cal-heatmap

Compilation and distribution is not done correctly

exoRift opened this issue · 2 comments

The compilation and distribution of this package for Typescript is not done properly.

I love this library and would love to use it, however, no .ts files should be shipped, it should only be .js and .d.ts files, but there is something wrong with the compilation flags and the proper declaration files are not created and the source code is shipped with what's generated.

This makes it so that cal-heatmap works in dev, but any time you try to create a production build (Like with NextJS, for example), it fails because the TS files get linted and are incorrect. (It's using the types from the TS files instead of assertive declaration files)

For now, I've compiled the project myself and have just hard-stuck it into my project, but this isn't a great resolution to this massive issue.

wa0x6e commented

Will take a closer look at that

Should be fixed in master, will proceed to more tests before releasing