Please start adding unit tests
leavengood opened this issue · 4 comments
This is a whole lot of code without any tests. Both the client and server should have a good test suite.
Before you spend too much time on this though, I would flesh out more of the system. But any new work would probably benefit from unit tests, especially something where you are having a lot of trouble (like file transfers.)
Well, the problem there turned out to be a race condition, which unit tests tend to not help with very much... But stuff like Recipe it's easy to add unit tests for, so I'm doing that now.
Just focus on best bang for the buck, testing things with a lot of branches, etc.
Recipe tests were added in 6850bab, I think that's good enough for now. (Looks like I forgot to close this then...)