Changes for code readability
alanhamlett opened this issue · 1 comments
alanhamlett commented
-
Let's rename this function because it's easily confused with
Sender.SendHeartbeats
, and vscode can't find implementations ofSender.SendHeartbeats
because it's an interface. That means you have to search forSendHeartbeats
, and the unrelated one shows up in the results. -
How about removing
NewClient
and only useNewClientWithoutAuth
then set the key on the request for fetching Goal and Today?
gandarez commented
- vscode or other IDEs like Goland will properly find this implementation as you can see in the screenshoot below. IMO it's well written and describes exactly what the func is proposed to do. Any thoughts?
- I wouldn't remove
NewClient
just becauseSendHeartbeat
doesn't need it. I'd keep it since Options pattern can benefit us for extensibility purposes. If new features come and authentication is neededNewClient
will be ready for it.