walkmod/walkmod-pmd-plugin

Modern art like if rewritings (missing code, wrong condition merging)

cal101 opened this issue · 2 comments

         try {
             pixelboxx = adminServlet.getCheckedPixelbox();
             action = callCtx.getInt("action", 0);
-            if (action == 0) {
-                if (callCtx.getString("startjob", null) != null) {
-                    action = 1;
-                }
+            if (action == (callCtx.getString("startjob", null) != null)(action == 0) && (callCtx.getString("startjob", null) != null)) {
             }

rpau commented

Thanks, this part probably is when walkmod rewrites the minimum set of changes, but thanks a lot

rpau commented

Fixed at 4617abc