Render frames in subfolder
C0D3D3V opened this issue · 7 comments
Hey cool project. I found your project, unfortunately only after I brought mine (https://github.com/C0D3D3V/bbb-dl) to the first version.
I just tested the tool, the frames are not rendered correctly. It only creates images that look like this:
It uses inkscape to do some conversions. Do you see the above instead of poll results?
The problem is that the href in the svg image is wrong.
If I open the file in inkscape it fixes the href with a warning.
<ns0:svg xmlns:ns0="http://www.w3.org/2000/svg" xmlns:ns1="http://www.w3.org/1999/xlink" id="svgfile" style="position:absolute;height:600px;width:800px" version="1.1" viewBox="0 0 800 600">
<ns0:image id="image7" class="slide" in="1024.1" out="1029.6" ns1:href="3052c10e5c0a2882113e7c6c9228d20f77e52c0a-1603349372038-slide-7.png" width="1600" height="1132" x="0" y="0" style="" text="presentation/3052c10e5c0a2882113e7c6c9228d20f77e52c0a-1603349372038/textfiles/slide-7.txt" />
</ns0:svg>
after the fix href is : ../3052c10e5c0a2882113e7c6c9228d20f77e52c0a-1603349372038-slide-7.png
And then the frame is rendered correctly.
I tested with this link: https://bbb-cluster.di.unito.it/playback/presentation/2.0/playback.html?meetingId=bd788745741ab787621c0dafa69a06ef91c0f02d-1603349301553
I tied with the above link, running
python3 $SOURCE_DIR/bbb-scrape/bbbscrape/main.py "https://bbb-cluster.di.unito.it/playback/presentation/2.0/playback.html?meetingId=bd788745741ab787621c0dafa69a06ef91c0f02d-1603349301553"
I do not see the above linked image not found failures. In particular I do see the drawings in the slides
How do you run it? Might be a working directory difference?
Maybe its a operating system thing... I use (Arch) Linux. Are you using Windows?
I had run it as:
bbb-scrape https://bbb-cluster.di.unito.it/playback/presentation/2.0/playback.html?meetingId=bd788745741ab787621c0dafa69a06ef91c0f02d-1603349301553
But that's no problem with small changes, it works for me too.
I tried the version installed via pip3 and I am also not seeing this (on Linux).
But that's no problem with small changes, it works for me too.
good to hear!
Hi, what are the changes? Anything we can change in the codebase to make it more robust? This part is pretty much "calibrated" with our own BBB instance only unfortunately..