wangf1978/DumpTS

CRC check of TLV/MMT stream

MMT-TLVassociation opened this issue · 4 comments

MMT-TLVassociation/DumpTS@c884656
(In crc.cpp, const uint8_t* is changed to uint8_t* . )

I added code to check CRC in DumpTS.

example:
DumpTS file.mmts --CID=1 --pid=0xF300 --output=e00301.hevc

If there are any CRC error in TLV/MMT stream, CRC false message is output.
I'll pull request if your are OK.

Hi, thanks for your contribution, it is ok for me, please go ahead.

Thank you.

Your codebase seems not to be a fork of the original source depot, I merged your changes manually, and I found some typos, and I changed it, the main change is
if (peek_msg_id == 0x8000 || 0x8002 || 0x8003 || 0x8004)// Packet_id, which includes CRC32
Changed it to
if (peek_msg_id == 0x8000 || peek_msg_id == 0x8002 || peek_msg_id == 0x8003 || peek_msg_id == 0x8004)// Packet_id, which includes CRC32

Please see commit

Yes, you are correct. Thank you for manually merging the changes.