Does not call player.dispose() on unMount - potential memory leak

Question

Does not call player.dispose() on unMount - potential memory leak

Mike-Bell opened this issue 8 years ago · 1 comments

On componentWillUnmount, we should call this.player && this.player.dispose();. Failing to do so will lead to memory leaks in the scenario that the component is dynamically added and removed on your page (found this out the hard way).

See http://docs.videojs.com/Player.html#dispose

Answer 1 · 2023-02-13T16:21:36.000Z

seems safe to say this will not be fixed