wantedly/step-pretty-slack-notify

notify_on not working

Closed this issue · 4 comments

LennardWesterveld commented

Hi there,

My build is successful and still getting slack notification.
So the notify_on is not working, i think the environment name is wrong.

    after-steps:
        - wantedly/pretty-slack-notify@0.2.11:
            webhook_url: *******
            notify_on: "failed"
            channel: ******
            username: *****

Result from wercker.

export WERCKER_PRETTY_SLACK_NOTIFY_BRANCHES=""
export WERCKER_PRETTY_SLACK_NOTIFY_NOTIFY_ON="failed"
koudaiii commented

Thank you for feed back 👍
I will try :)
Please wait a little. 🙇

dtan4 commented

We fixed this bug at #22 , and released as v0.2.12 :shipit: Please try this.
Thank you for reporting the issue ❗

LennardWesterveld commented

Hi there is still not working for me, the exported ENV is still WERCKER_PRETTY_SLACK_NOTIFY_NOTIFY_ON i see in code thats it needs to be WERCKER_PRETTY_SLACK_NOTIFY_ON

koudaiii commented

Sorry...Thank you for feed back. 🙇
Released v0.2.13 ❗ ❗