warden-stack/Warden

Process Watcher support for remote computer

samjudson opened this issue · 6 comments

Hi

It would be great if the ProcessWatcher supported remote computers. We have an environment with multiple service boxes all running the same service. It would be much easier to have a window Warden application to be able to monitor all the services running on all the boxes, rather than have to install the watcher on each service box (unless I'm misunderstanding how Warden works).

Sam

spetz commented

Hello,
Thanks for reporting this feature, I'll take a look what can be done in that matter.

Shouldn't be too hard :)

Process.GetProcessesByName takes a second parameter for the machine name, so you 'just' need to change the IProcessService.GetProcessInfoAsync method to take an optional second parameter for the machine name, and update the ProcessWatcherConfiguration class to have a MachineName property.

I can do a simple pull request if you'd like?

spetz commented

Sure, feel free to create a PR. The remote server might be an optional parameter :).

spetz commented

Thanks for the contribution, I've also updated the extension methods to be able to provide an optional machineName parameter. I'll release the new version of the libraries probably in the next week, as there are few more features coming as well :).

I've noticed that the extension method with 2 string parameters now results in an ambiguous invocation error.

spetz commented

Good point, I've just fixed it so this method is more explicit now.