warm-metal/container-image-csi-driver

Change the repository name to container-image-csi-driver

mugdha-adhav opened this issue · 7 comments

mugdha-adhav commented

See #91 for more details.

mugdha-adhav commented

Noting down some of the action items I could think of -

  • Change repository name in GitHub settings.
  • Change default branch to main from master.
  • Update go dependency files (go.mod & go.sum).
  • Update the references of repository name while running integration tests.
  • Test and update the Make targets.
  • Update image name to container-image-csi-driver in manifests and update registry references.

Because most of the above mentioned points are inter-dependent and would cause breaking changes, I think we should have a single PR for all the identified changes.

mugdha-adhav commented

Adding links to some reference reading material I found -

mbtamuli commented

Because most of the above mentioned points are inter-dependent and would cause breaking changes, I think we should have a single PR for all the identified changes.

Can we also add one more thing to this? Renaming the master branch to main - https://github.com/github/renaming#renaming-existing-branches. It would also cause breaking changes, at least for existing forks. Better to rip-off the band-aid in one go.

  • 👍1
  • 👀1
mugdha-adhav commented

Updated README with the name change notice.

mbtamuli commented

FYI @mugdha-adhav, Argo Workflows also renamed the default branch - argoproj/argo-workflows#12127

  • 👀1
mbtamuli commented

@mugdha-adhav I'm creating a PR for fixing the workflows.

  • 👍1
mugdha-adhav commented

All of the action items seems to have been addressed for now. Closing this issue, please feel free to raise an issue if we might have missed something.