washingtonstateuniversity/WSUWP-spine-parent-theme

Spacing of Social Icons

Closed this issue · 4 comments

There's a coffee on me for whoever is able to determine why the social icons in WordPress installs are aligned too tightly (right).
screen shot 2014-09-03 at 1 55 58 pm
All the relevant properties seem identical.
screen shot 2014-09-03 at 1 58 43 pm
screen shot 2014-09-03 at 1 59 01 pm

To do your own comparison, you could compare...

https://repo.wsu.edu/spine/1/tests/grid_fluid.html

To

http://brand.wsu.edu

There is whitespace between the <li> elements in the grid fluid test HTML. When displayed as inline-block, this whitespace annoyingly appears.

I guess the fix here could be to add whitespace to the generation of the social icons. I'm not sure what the best scenario to plan on is.

For visual comparion:

Grid Fluid:

    <nav id="wsu-social-channels" class="spine-social-channels">
        <ul>
            <li class="facebook-channel"><a href="http://facebook.com/wsupullman">Facebook</a></li>
            <li class="twitter-channel"><a href="http://twitter.com/wsupullman">Twitter</a></li>
            <li class="youtube-channel"><a href="http://www.youtube.com/washingtonstateuniv">YouTube</a></li>
            <li class="directory-channel"><a href="http://social.wsu.edu">Directory</a></li>
        </ul>
    </nav>

Brand:

    <nav id="wsu-social-channels" class="spine-social-channels">
        <ul>
        <li class="facebook-channel"><a href="http://www.facebook.com/WSUPullman">facebook</a></li><li class="twitter-channel"><a href="http://twitter.com/wsupullman">twitter</a></li><li class="youtube-channel"><a href="http://www.youtube.com/washingtonstateuniv">youtube</a></li><li class="directory-channel"><a href="http://social.wsu.edu">directory</a></li>        </ul>
    </nav>

And for the specific fix, a carriage return in this loop would generate the whitespace.

Don't let me forget to buy you that coffee, @jeremyfelt.