washingtonstateuniversity/WSUWP-spine-parent-theme

Prefix all custom functions

Closed this issue · 3 comments

jeremyfelt commented

This isn't necessarily an immediate concern, but should be thought of before the parent is used by many.

Functions like is_subpage(), section_title(), and section_slug() should be prefixed with spine_theme_ as spine_theme_is_subpage(), etc.. to avoid unintentional conflicts with other theme, plugin, or future WordPress core code.

Any change that addresses this should mirror any necessary changes in the child theme(s) that could be using the functions as well.

natejacobson commented

You're right... but — "spine_theme_is_subpage()" — yuck :) We could probably remain responsible citizens with "spine_is_subpage()", no?

jeremyfelt commented

We could, though one naming convention is better. We should be okay if we use spine_ to prefix all functions rather than spine_theme_.

jeremyfelt commented

We're good on this now.