[FEATURE] Improve wadm manifest validation
lachieh opened this issue · 7 comments
From @brooksmtownsend:
wadm manifest validation should not accept spread blocks being empty or at the wrong indentation level. I assume this is because we allow spread blocks to be empty, but perhaps we could validate this better.
We should improve the validation behavior of wadm so that it is a little more strict in the places that it accepts "extra" data. This could be handled by improving the json schema which is probably the better way since this validation is used in other clients.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud!
Probably still valid
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud!
@brooksmtownsend @vados-cosmonic would you say that #274 closed this?
@vados-cosmonic Is the validation logic in its own crate? I'd like to be able to make use of it in a wasm module that takes a string and returns validation errors/success.
Hey @lachieh yeah -- so wadm got refactored into a bunch of crates, and it's in wadm-types:
https://crates.io/crates/wadm-types
In particular: https://docs.rs/wadm-types/0.1.0/wadm_types/validation/index.html
Should be easy to (re)use now!
Ok, awesome. Thanks @vados-cosmonic!