wasmerio/wasmer

Broken on nightly because of ahash 0.7 (aka "update hashbrown")

Closed this issue · 5 comments

Manishearth commented

ahash@0.7 is as of yesterday broken on Rust nightly, even if you do not choose to opt in to its nightly features, because it autoenables features in build.rs. See tkaitchuck/aHash#200.

This problem is fixed in ahash@0.8. However, this crate and its dependencies use ahash 0.7 via hashbrown@0.11 and hashbrown@0.12, used by object@0.28 and indexmap@1.9 respectively. object@0.32 and indexmap@2.0 are up to date.

Ideally wasmer should be updated to use the latest hashbrown.

I do have some alternate ways of solving this problem:

however I think it's worth updating hashbrown anyway.

This breaks older versions of wasmer as well, ideally these deps can be updated for the wasmer 2.x and 3.x series.

Thanks!

theduke commented

Thanks for the ping.
This will require some annoying dependency juggling because some dependencies are stuck on older versions to avoid duplicates.

theduke commented

So it seems hashbrown has fixed this in 0.7.8, which means users can run cargo update and things will work.

We will also update the lockfile to have ahash@0.7.8 reflected in there.

theduke commented

Closing as fixed upstream.