watadarkstar/react-native-typing-animation

there is no such prop for hiding and showing the prop [feature request]

dharmendrashah opened this issue · 7 comments

dharmendrashah commented

i want to add this in my chat application but i didn't see any options for showing and hiding this prop i can do this by our own side but it will be very helpful that it will be the initiated prop option in this modules.

Deleted user commented

Hi @dharmendrashah, this feature will be released soon. What do you say @watadarkstar? I can start working on this right away.

watadarkstar commented

@murageden Happy to have you add a prop that lets the user hide the component. Like so:

  • hide (Bool) - When set to true it hides the component

If that's what is being asked?

Deleted user commented

Feature request. Sure. I will make a PR as soon as I get on my desk. Thank you @watadarkstar😊

  • 👍1
watadarkstar commented

@dharmendrashah Do you mean hiding the component? Because you said "hiding this prop" but that doesn't make sense to me.

  • 👍1
Deleted user commented

Yeah, obviously he means the whole view/ Component. I understand @dharmendrashah 's limbo. But we want to keep the library as light as possible, that's why we are making just the loader. The functionality for the loader is considered external to the loader. This feature will only be limited to allowing: make the component shown/hidden. It won't include things like timing the showing/hiding states.

  • 👍1
Deleted user commented

@watadarkstar, I raised a request for this feature, kindly review and merge. @dharmendrashah this should be fixed after the merge. This issue should be marked as closed now, @watadarkstar.

watadarkstar commented

This has been merged in as of PR #25