Support GitHub application with multiple installations
Oded-B opened this issue · 3 comments
Description
GitHub apps have an "installation object" per github org.
They authenticate by generating a per-installation token, at the moment telefonistka GitHub App auth only support a single installation so it can't serve webhooks from multiple GH orgs.
Expected Behaviour
When using GitHub App auth, telefonistka should generate(and cache) per-installation token during webhook handling (and not during startup)
This seems like a nice example using LRU cache for a similar usecase:
https://github.com/palantir/go-githubapp/blob/afc69e5e3ae0826c3f7848ef8f6caafe11a4127f/githubapp/caching_client_creator.go#L74
Actual Behaviour
telefonistka just use the first installation provided by the GH API, events from other GH orgs just fails
Affected Version
Please provide the version number where this issue was encountered.
Steps to Reproduce
- First step
- Second step
- etc.
Checklist
- I have read the contributing guidelines
- I have verified this does not duplicate an existing issue
test
Automatically marking issue as stale due to lack of activity
Automatically closing this issue as stale